Skill Points Script revised (not so broken I hope)

[Gando]

Ok so I promised Id post this when I was more compus mentus and here I am awake and as compus as Ill get...so here goes:

first
in init.lua

sp_str = 0
sp_int = 0
sp_wis = 0
sp_dex = 0
sp_con = 0
sp_cha = 0
sp_class = 0

notes: the initial plan was to use an array (as Im a js coder Im used to using arrays to deal with objects etc...makes for more efficient coding) but for some reason a global array defined in init.lua kept zeroing out the stats so I settled for individual variables instead.

next...
in passive.lua starting on line 1288

sp_str = p_ptr.stat_ind[A_STR+1]
sp_int = p_ptr.stat_ind[A_INT+1]
sp_wis = p_ptr.stat_ind[A_WIS+1]
sp_dex = p_ptr.stat_ind[A_DEX+1]
sp_con = p_ptr.stat_ind[A_CON+1]
sp_cha = p_ptr.stat_ind[A_CHR+1]
sp_class = p_ptr.pclass

I decided to follow Variaz's last advice concerning which stat to use. also decided to put the class into a variable just in case using it in the other script was goofy.

next...

in scripts.lua

on line 14

function get_bonus_sp ()
local arBonus={}
--warriors and fighters
arBonus[1] = (sp_str/5) + (sp_con/5) + 2
arBonus[2] = (sp_str/5) + (sp_con/5) + 2
--mages and priests
arBonus[3] = (sp_int/5) + (sp_wis/5) + 2
arBonus[4] = (sp_int/5) + (sp_wis/5) + 2
--rogues
arBonus[5] = (sp_dex/5) + (sp_int/5) + 2
--rangers
arBonus[6] = (sp_str/5) + (sp_dex/5) + 2
--paladins
arBonus[7] = (sp_wis/5) + (sp_cha/5) + 2
--monks
arBonus[8] = (sp_wis/5) + (sp_con/5) + 2
--marksmen
arBonus[9] = (sp_dex/5) + (sp_con/5) + 2
--highmages
arBonus[10] = (sp_int/5) + (sp_wis/5) + 2
--elemental lords
arBonus[11] = (sp_str/5) + (sp_int/5) + 2
--monster mages
arBonus[12] = (sp_int/5) + (sp_con/5) + 2
--defenders
arBonus[13] = (sp_str/5) + (sp_con/5) + 2
--justice warriors
arBonus[14] = (sp_wis/5) + (sp_cha/5) + 2
--high monks
arBonus[15] = (sp_wis/5) + (sp_con/5) + 2
--soul guardians
arBonus[16] = (sp_wis/5) + (sp_cha/5) + 2
--shadow stalkers
arBonus[17] = (sp_dex/5) + (sp_int/5) + 2
--gunners
arBonus[18] = (sp_dex/5) + (sp_con/5) + 2
--enchanters
arBonus[19] = (sp_int/5) + (sp_wis/5) + 2
--apprentices and monsters get 5 total
if (sp_class == CLASS_APPRENTICE or p_ptr.prace == RACE_MONSTER) then
return 5
end
msg_print("You get some sp equal to ")
msg_print(arBonus[sp_class])
return arBonus[sp_class]
end


on line 67 in function skill_points_per_levels()

amt = get_bonus_sp()


and finally (very important)
on line 409


add_event_handler("get_bonus_sp", get_bonus_sp)


Notes:
The function I wrote is very simple...it assigns sp gain formula to an array the length of the number of classes in game.
If a new class gets added the array will need an additional element.
Then it returns the sp gained according to the current class of the character...I have not tested what happens when you have 2 classes (pal 3 war 3 for example) so this is still an iffy script.

the line in skill_points_for_levels that I altered calls the function and assigns its return value to the amt variable that it will return to the game.

The last thing I added is important to add an event handler for the new function so the game doesnt freak out (or just ignore it and do something odd)

[Variaz]

Looks like it works now. Let us know how good that script is after you've playtested a bit!

[Gando]

Apparently the formula I used is a bit too generous particularly combined with the Enchanter class. Im a level 11 enchanter with 86 crafting and 50 alchemy ...so Im thinking stat/10 + stat/10 + 3 with a skill point cap of 10 per level. What is the round up function for Lua? I cant seem to find one. Rounding up 1/10th would be better than rounding 1/5th out.

[Variaz]

I think it's "round" but I'm not sure. If it's integer, though, you don't need rounding.

[Gando]

Whenever you divide numbers you chance getting fractions ..ie 9/10 should be 1 not 0...

[Gando]

So far the script has worked fine through 3 class changes so Im thinking its stable...once the values change a bit it should be usable.

[Gando]

I did some alterations that seem to be working so far

I added some functions that seemed to be missing from lua or obscured at any rate:



function rounded_remainder(remainder)
if remainder > 4 then return 1 end
return 0
end

function find_remainder(x, y)
local r = x - y
while (r > -1) do
r = r - y
end
if (r == 0) then r = r
else
r = r + y end
return r
end



and changed the get_bonus_sp function as follows:

function get_bonus_sp ()
local arBonus={}
--warriors and fighters
arBonus[1] = (sp_str/10) + (sp_con/10) + rounded_remainder(find_remainder(sp_str, 10)) + rounded_remainder(find_remainder(sp_con, 10))
arBonus[2] = (sp_str/10) + (sp_con/10) + rounded_remainder(find_remainder(sp_str, 10)) + rounded_remainder(find_remainder(sp_con, 10))
--mages and priests
arBonus[3] = (sp_int/10) + (sp_wis/10) + rounded_remainder(find_remainder(sp_int, 10)) + rounded_remainder(find_remainder(sp_wis, 10))
arBonus[4] = (sp_int/10) + (sp_wis/10) + rounded_remainder(find_remainder(sp_int, 10)) + rounded_remainder(find_remainder(sp_wis, 10))
--rogues
arBonus[5] = (sp_int/10) + (sp_dex/10) + rounded_remainder(find_remainder(sp_int, 10)) + rounded_remainder(find_remainder(sp_dex, 10))
--rangers
arBonus[6] = (sp_str/10) + (sp_dex/10) + rounded_remainder(find_remainder(sp_str, 10)) + rounded_remainder(find_remainder(sp_dex, 10))
--paladins
arBonus[7] = (sp_cha/10) + (sp_wis/10) + rounded_remainder(find_remainder(sp_cha, 10)) + rounded_remainder(find_remainder(sp_wis, 10))
--monks
arBonus[8] = (sp_con/10) + (sp_wis/10) + rounded_remainder(find_remainder(sp_con, 10)) + rounded_remainder(find_remainder(sp_wis, 10))
--marksmen
arBonus[9] = (sp_dex/10) + (sp_con/10) + rounded_remainder(find_remainder(sp_dex, 10)) + rounded_remainder(find_remainder(sp_con, 10))
--highmages
arBonus[10] = (sp_int/10) + (sp_wis/10) + rounded_remainder(find_remainder(sp_int, 10)) + rounded_remainder(find_remainder(sp_wis, 10))
--elemental lords
arBonus[11] = (sp_int/10) + (sp_str/10) + rounded_remainder(find_remainder(sp_int, 10)) + rounded_remainder(find_remainder(sp_str, 10))
--monster mages
arBonus[12] = (sp_int/10) + (sp_con/10) + rounded_remainder(find_remainder(sp_int, 10)) + rounded_remainder(find_remainder(sp_con, 10))
--defenders
arBonus[13] = (sp_str/10) + (sp_con/10) + rounded_remainder(find_remainder(sp_str, 10)) + rounded_remainder(find_remainder(sp_con, 10))
--justice warriors
arBonus[14] = (sp_cha/10) + (sp_wis/10) + rounded_remainder(find_remainder(sp_cha, 10)) + rounded_remainder(find_remainder(sp_wis, 10))
--high monks
arBonus[15] = (sp_con/10) + (sp_wis/10) + rounded_remainder(find_remainder(sp_con, 10)) + rounded_remainder(find_remainder(sp_wis, 10))
--soul guardians
arBonus[16] = (sp_cha/10) + (sp_wis/10) + rounded_remainder(find_remainder(sp_cha, 10)) + rounded_remainder(find_remainder(sp_wis, 10))
--shadow stalkers
arBonus[17] = (sp_dex/10) + (sp_int/10) + rounded_remainder(find_remainder(sp_dex, 10)) + rounded_remainder(find_remainder(sp_int, 10))
--gunners
arBonus[18] = (sp_dex/10) + (sp_con/10) + rounded_remainder(find_remainder(sp_dex, 10)) + rounded_remainder(find_remainder(sp_con, 10))
--enchanters
arBonus[19] = (sp_int/10) + (sp_wis/10) + rounded_remainder(find_remainder(sp_int, 10)) + rounded_remainder(find_remainder(sp_wis, 10))
--apprentices and monsters get 5 total
if (sp_class == CLASS_APPRENTICE or p_ptr.prace == RACE_MONSTER) then
return 5
end
return arBonus[sp_class]
end

and finally altered skill_points_per_levels () as follows


function skill_points_per_levels ()

local amt
local msg_string
amt = get_bonus_sp()
if (amt > 10) then amt = 10 end
if (amt < 5) then amt = 5 end

-- Humans gets more.
if (p_ptr.prace == RACE_HUMAN and (lua_mod(p_ptr.lev, 3))) then amt = amt + 1 end

msg_string = "You recieve " .. amt .. " skill points!"
msg_print(msg_string)
return (amt)
end


Notes: Currently there is a maximum sp and minimum sp set...I might remove the minimum sp and see if that is too little to start with... Clearly the max cap is needed as without it the skill points eventually get out of hand with some classes (ie: enchanter right now and eventually all the good classes once the game is playable to level 100.)

Essentially my premise was that it should be set up so that you gain more sp by focusing on the stats your class is strong in. I'm not totally sure how balanced this will be but my theory with bands is that the idea is to have fun and balance is secondary to that.